Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): track ratio between unknown nodes and all type nodes #6125

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 25, 2024

Description

we want to track the ratio between unknown type nodes and all type nodes. This help us track how well built out feature wise we are

What to review

Testing

n/a

Notes for release

n/a - no notes needed

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 26, 2024 8:44am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 8:44am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 8:44am

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

@sgulseth sgulseth marked this pull request as ready for review March 25, 2024 11:04
@sgulseth sgulseth requested review from a team as code owners March 25, 2024 11:04
@sgulseth sgulseth requested review from binoy14 and removed request for a team March 25, 2024 11:04
Copy link
Contributor

github-actions bot commented Mar 25, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Component Testing Report Updated Mar 26, 2024 8:47 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@sgulseth sgulseth requested a review from tzhelyazkova March 25, 2024 19:28
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgulseth sgulseth added this pull request to the merge queue Mar 26, 2024
Merged via the queue into next with commit 3822da2 Mar 26, 2024
35 of 36 checks passed
@sgulseth sgulseth deleted the 03-25-chore_codegen_track_ratio_between_unknown_nodes_and_all_type_nodes branch March 26, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants