Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vision): fixes bug where codemirror would insert a new line on cmd-return #6123

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(vision): fixes bug where codemirror would insert a new line on cmd-return #6123

merged 1 commit into from
Mar 26, 2024

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 24, 2024 •
edited
Loading

Description

Fixes an annoying bug where code mirror would insert another new line on cmd-return, which also executes the query

What to review

Should be safe, tested fine on mac

Testing

n/a

Notes for release

Fix bug where Vision would insert another new line on cmd-return.

@vercel Vercel
Copy link

vercel bot commented Mar 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 26, 2024 8:41am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 8:41am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 8:41am

@sgulseth Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@sgulseth sgulseth marked this pull request as ready for review March 24, 2024 23:44
@sgulseth sgulseth requested a review from a team as a code owner March 24, 2024 23:44
@sgulseth sgulseth requested review from juice49 and removed request for a team March 24, 2024 23:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2024 •
edited
Loading

Component Testing Report Updated Mar 26, 2024 8:45 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@sgulseth sgulseth force-pushed the 03-25-fix_vision_fixes_bug_where_codemirror_would_insert_a_new_line_on_cmd-return branch from 307fec9 to 59726aa Compare March 24, 2024 23:52
@sgulseth sgulseth force-pushed the 03-25-fix_vision_fixes_bug_where_codemirror_would_insert_a_new_line_on_cmd-return branch from 59726aa to 11fb8ef Compare March 25, 2024 20:36
@sgulseth sgulseth force-pushed the 03-25-fix_vision_fixes_bug_where_codemirror_would_insert_a_new_line_on_cmd-return branch from 11fb8ef to 17098dc Compare March 26, 2024 08:38
juice49
juice49 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic change. Thanks!

@juice49 juice49 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into next with commit 971ba9f Mar 26, 2024
36 checks passed
@juice49 juice49 deleted the 03-25-fix_vision_fixes_bug_where_codemirror_would_insert_a_new_line_on_cmd-return branch March 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juice49 juice49 juice49 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgulseth @juice49