Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): correctly assert optional fields with enforce required fields #6121

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Mar 24, 2024

Description

We were asserting the optional value wrong for required fields 🤦

What to review

Agree that it's correct now?

Testing

Notes for release

fixes a bug, where all fields got marked as non-optional, when extracting schema with --enforce-required-fields

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 25, 2024 0:02am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 0:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 0:02am

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

Copy link
Contributor

No changes to documentation

@sgulseth sgulseth force-pushed the 03-24-fix_schema_correctly_assert_optional_fields_with_enforce_required_fields branch from 417c75e to c7c2803 Compare March 24, 2024 06:28
@sgulseth sgulseth marked this pull request as ready for review March 24, 2024 06:30
@sgulseth sgulseth requested a review from a team as a code owner March 24, 2024 06:30
@sgulseth sgulseth requested review from jtpetty and removed request for a team March 24, 2024 06:30
Copy link
Contributor

github-actions bot commented Mar 24, 2024

Component Testing Report Updated Mar 25, 2024 12:06 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

@sgulseth sgulseth added this pull request to the merge queue Mar 25, 2024
Merged via the queue into next with commit f568e14 Mar 25, 2024
57 of 61 checks passed
@sgulseth sgulseth deleted the 03-24-fix_schema_correctly_assert_optional_fields_with_enforce_required_fields branch March 25, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants