-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codegen): attempt to parse groq queries with parameter in slices #6117
Merged
rexxars
merged 1 commit into
next
from
03-22-feat_codegen_attempt_to_parse_groq_queries_with_parameter_in_slices
Mar 26, 2024
Merged
feat(codegen): attempt to parse groq queries with parameter in slices #6117
rexxars
merged 1 commit into
next
from
03-22-feat_codegen_attempt_to_parse_groq_queries_with_parameter_in_slices
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Full Report@sanity/codegen
@sanity/migrate
sanity
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
sanity/structure
@sanity/util/concurrency-limiter
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/client
@sanity/util/createSafeJsonParser
sanity/_internalBrowser
@sanity/util/content
|
Component Testing Report Updated Mar 26, 2024 8:47 AM (UTC)
|
ricokahler
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks safe to me!
sgulseth
force-pushed
the
03-22-feat_codegen_attempt_to_parse_groq_queries_with_parameter_in_slices
branch
from
March 25, 2024 20:36
bf21911
to
378b988
Compare
sgulseth
force-pushed
the
03-22-feat_codegen_attempt_to_parse_groq_queries_with_parameter_in_slices
branch
from
March 26, 2024 08:38
378b988
to
772bcaf
Compare
rexxars
deleted the
03-22-feat_codegen_attempt_to_parse_groq_queries_with_parameter_in_slices
branch
March 26, 2024 16:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to find occurrences of parameters used in groq queries, and extract the parameter.
What to review
Can this have any unintended side effects?
Testing
Any more variants we should test for?
Notes for release
n/a - no notes needed