fix(form): prevent drop event propagating outside of EditPortal component #5813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Feb 29, 2024 11:28 AM (UTC)
|
juice49
force-pushed
the
fix/sdx-502-edit-portal-drop-zone-leak
branch
from
fc51c03 to
838d348
Compare
juice49
requested review from
hermanwikner,
bjoerge and
a team
and removed request for
a team
bjoerge
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
EditPortaldialog is open for an object in an array, the array input itself still responds todropevents. This means it's possible to drop a file on the array while it's behind a modal dialog and appears to be inert.It's particularly problematic if a user attempts to drop a file into the dialog itself, but slightly misses the drop zone, causing the file to be dropped onto the array.
What to review
test/structure/input standard;arraysTest;0154c37b-c15a-41bc-9779-54a6c1db4889).EditPortaldialog is open, attempt to drop a file onto the dialog or its backdrop. The file should not be added to the list input.Testing
E2E test included.
Notes for release
Fixes an issue that allowed files to be dropped behind the open modal (where the inputs appeared to be inert).