Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): respect unattended mode #5659

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 2, 2024

Description

A recent change to the CLI added user prompts when attempting to use a nonexistent coupon (--coupon) or a plan (--project-plan), however, this change did no respect unattended mode (-y, --yes) and would prompt the user regardless.

What to review

  • Initialising a project using a nonexistent coupon or plan in unattended mode:
    • init -y --project-plan beep
    • init -y --coupon boop

Testing

  • Does the command proceed without prompting the user?

@juice49 juice49 requested a review from a team as a code owner February 2, 2024 16:32
@juice49 juice49 requested review from rexxars and removed request for a team February 2, 2024 16:32
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ❌ Failed (Inspect) Feb 5, 2024 9:30am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 9:30am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 9:30am

Copy link
Contributor

github-actions bot commented Feb 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Component Testing Report Updated Feb 5, 2024 9:33 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 14s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 19s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 4s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

@juice49 juice49 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into next with commit 0e0fd1f Feb 6, 2024
39 of 40 checks passed
@juice49 juice49 deleted the fix/cli-init-unattended-mode branch February 6, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants