Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add aria label to action button pte toolbar #5653

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

ninaandal
Copy link
Contributor

Description

Adds aria-label to the PTE toolbar action menus

What to review

Testing

Notes for release

@ninaandal ninaandal requested a review from a team February 2, 2024 12:07
@ninaandal ninaandal requested a review from a team as a code owner February 2, 2024 12:07
@ninaandal ninaandal requested review from sjelfull and binoy14 and removed request for a team February 2, 2024 12:07
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 19, 2024 3:41pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 3:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 3:41pm

Copy link
Contributor

github-actions bot commented Feb 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Component Testing Report Updated Feb 19, 2024 3:45 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 22s 0 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are failing tests, this is very likely due the fact that the failing tests are not wrapped in LocaleProvider and cannot find the correct locale to display the text. Let me know if you need help in fixing that.

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@sjelfull sjelfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ninaandal ninaandal added this pull request to the merge queue Feb 22, 2024
Merged via the queue into next with commit 0794d72 Feb 22, 2024
40 checks passed
@ninaandal ninaandal deleted the edx-95 branch February 22, 2024 15:15
bjoerge added a commit that referenced this pull request Feb 23, 2024
bjoerge added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants