-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comments): adds read-only state to comments. #5570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pedrobonamin
commented
Jan 26, 2024
Full Reportsanity
@sanity/migrate
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/createSafeJsonParser
sanity/_internalBrowser
@sanity/util/content
|
Component Testing Report Updated Feb 6, 2024 4:28 PM (UTC)
|
pedrobonamin
commented
Jan 26, 2024
packages/sanity/src/structure/comments/src/components/upsell/UpsellDialog.tsx
Outdated
Show resolved
Hide resolved
pedrobonamin
commented
Jan 26, 2024
packages/sanity/src/structure/comments/src/hooks/useResolveCommentsEnabled.ts
Outdated
Show resolved
Hide resolved
pedrobonamin
requested review from
hermanwikner
and removed request for
a team
January 29, 2024 09:20
pedrobonamin
force-pushed
the
edx-973
branch
2 times, most recently
from
February 6, 2024 16:16
e054e23
to
6a6ef96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DescriptionSerializer
fromsanity
package for reusability in comments plugin.After free trial, it adds read only state to comments, showing the comments in a disabled state and only allowing to:
It removes the ability to:
Introduces new upsell UI into the comments inspector panel.
What to review
Comments functionality, nothing should change for enabled plans.
Testing
Notes for release