Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facelift): studio UI butons #5117

Closed
wants to merge 12 commits into from

Conversation

pedrobonamin
Copy link
Contributor

Description

Adds new SanityUI component Button
Replaces import {Button} from "@sanity/ui" for Studio UI button.
Adds default props for padding and font size.

All padding={2} buttons received size="small" prop. The rest of the buttons will take the default values.

Updates the Publish document button, to match with facelift redesign.

What to review

Uses of button across the app.
Specially buttons that have not been updated.

Notes for release

Integrates Studio UI Buttons.

robinpyon and others added 12 commits October 10, 2023 11:25
* feat(facelift): create StudioUI tooltip with delay and replace

* fix(core/desk): use StudioUi Tooltip

* fix(core/desk): use Studio UI tooltip

* fix(core/desk): use StudioUI tooltip and remove paddings

* fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

* fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic

* fix(vision): change tooltip import path

* fix(src): fix up content in StudioUI tooltips, remove comment

* fix(core): add two arguments to forwardRef render function

* fix(test-studio): add custom badge to author schema type

* Update packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <[email protected]>

* refactor: slightly DRY tooltip component

---------

Co-authored-by: Robin Pyon <[email protected]>
Co-authored-by: Robin Pyon <[email protected]>
Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Nov 3, 2023 7:40am
test-studio ✅ Ready (Inspect) Visit Preview Nov 3, 2023 7:40am
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 3, 2023 7:40am

Copy link
Contributor

github-actions bot commented Nov 3, 2023

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Component Testing Report Updated Nov 3, 2023 7:47 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 26s 11 0 1
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 4s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 15s 2 0 1
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 26s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 12s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 49s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@pedrobonamin
Copy link
Contributor Author

Closing this PR in favour of #5118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants