Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint errors #5112

Closed
wants to merge 1 commit into from
Closed

chore: fix lint errors #5112

wants to merge 1 commit into from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Nov 2, 2023

Fixes various lint errors that we got after #5600

@vercel Vercel
Copy link

vercel bot commented Nov 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Nov 2, 2023 4:56pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 4:56pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 2, 2023 4:56pm

@bjoerge bjoerge removed the request for review from RitaDias November 2, 2023 16:52
@binoy14
Copy link
Contributor

binoy14 commented Nov 2, 2023

Should we maybe look into merging #5033 instead? That should fix the errors

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Component Testing Report Updated Nov 2, 2023 5:00 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 26s 12 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 4s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 27s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 13s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 50s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 6s 3 0 0

@bjoerge
Copy link
Member Author

bjoerge commented Nov 3, 2023

Should we maybe look into merging #5033 instead? That should fix the errors

Good call – I've merged #5033 instead

@bjoerge bjoerge closed this Nov 3, 2023
@bjoerge bjoerge deleted the chore/fix-eslint-errors branch November 3, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

@skogsmaskin skogsmaskin Awaiting requested review from skogsmaskin

@binoy14 binoy14 Awaiting requested review from binoy14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjoerge @binoy14 @rexxars