Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sanity): fix resolveUploader typings #4916

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Sep 11, 2023

Description

Fixes a ts-error that started occurring after upgrading to latest @sanity/ui (see https://github.com/sanity-io/sanity/actions/runs/6148137123/job/16681186526)

I didn't investigate why it suddenly started happening, but my hunch is that latest @sanity/ui fixes a typing issue that surfaces a bug with our own typings. This PR works around the issue with an any for now.

What to review

  • Type checker is happy

Notes for release

  • N/A internal

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 11, 2023 8:41pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 8:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2023 8:41pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Component Testing Report Updated Sep 11, 2023 8:44 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 8s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 11s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 42s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 10s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@bjoerge bjoerge changed the title chore(sanity): fix ts error and optimize imports chore(sanity): fix resolveUploader typings Sep 11, 2023
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoerge bjoerge added this pull request to the merge queue Sep 13, 2023
Merged via the queue into next with commit 112a46a Sep 13, 2023
13 checks passed
@bjoerge bjoerge deleted the chore/fix-ts-error branch September 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants