Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): drop Node v16 from test matrix, add Node v20 #4913

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore(ci): drop Node v16 from test matrix, add Node v20 #4913

merged 1 commit into from
Sep 13, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Sep 11, 2023 •
edited
Loading

Description

Node 16 goes out of maintenance LTS today, so let's drop it form our test matrix. Also, probably a good idea to add v20 now.

What to review

  • Tests are passing

Notes for release

  • Drop Node 16.x from CI test matrix

@vercel
Copy link

vercel bot commented Sep 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 12, 2023 8:40am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 8:40am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2023 8:40am

@bjoerge bjoerge requested review from rexxars and binoy14 September 11, 2023 08:51
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023 •
edited
Loading

Component Testing Report Updated Sep 12, 2023 8:43 AM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 50s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@github-actions
Copy link
Contributor

No changes to documentation

@bjoerge bjoerge requested a review from skogsmaskin September 12, 2023 08:27
binoy14
binoy14 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@bjoerge bjoerge added this pull request to the merge queue Sep 13, 2023
Merged via the queue into next with commit 67696cb Sep 13, 2023
14 checks passed
@bjoerge bjoerge deleted the chore/drop-node-16 branch September 13, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binoy14 binoy14 binoy14 approved these changes

@rexxars rexxars Awaiting requested review from rexxars

@skogsmaskin skogsmaskin Awaiting requested review from skogsmaskin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoerge @binoy14