Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused useConditionalReadOnly hook #4902

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 7, 2023

Description

Found this hook while refactoring, but did not find any place we were rendering the context provider - so assuming it is unused.

What to review

  • Conditional read only fields still work as expected

Notes for release

None, internal change.

@rexxars rexxars requested review from sjelfull and a team September 7, 2023 00:03
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Sep 7, 2023 0:05am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 7, 2023 0:05am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Component Testing Report Updated Sep 7, 2023 12:08 AM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 11s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 43s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Package Documentation Change
@sanity/portable-text-editor +5%
@sanity/types +2%
sanity -1%
sanity/desk -3%
Full Report
@sanity/portable-text-editor
This branch Current release
21 documented 20 documented
44 not documented 44 not documented
@sanity/types
This branch Current release
46 documented 45 documented
240 not documented 240 not documented
@sanity/diff
This branch Current release
13 documented 13 documented
16 not documented 0 not documented
@sanity/block-tools
This branch Current release
4 documented 4 documented
9 not documented 9 not documented
@sanity/mutator
This branch Current release
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Current release
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Current release
0 documented 0 documented
9 not documented 8 not documented
@sanity/util/paths
This branch Current release
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Current release
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Current release
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Current release
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Current release
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Current release
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Current release
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Current release
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Current release
1 documented 1 documented
5 not documented 4 not documented
sanity
This branch Current release
109 documented 110 documented
835 not documented 856 not documented
sanity/desk
This branch Current release
83 documented 85 documented
54 not documented 54 not documented

Copy link
Member

@sjelfull sjelfull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is unused, yes. This was replaced by resolveConditionalProperty in v3.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@rexxars rexxars added this pull request to the merge queue Sep 7, 2023
Merged via the queue into next with commit b99e332 Sep 7, 2023
14 checks passed
@rexxars rexxars deleted the refactor/remove-unused-hook branch September 7, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants