Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): convert array input actions strings to use i18n primitives #4866

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Aug 24, 2023

Description

Convert array input strings to use i18n primitives

TO DO still in PR:

ArrayOfPrimitivesInput

  • ArrayOfPrimitivesInput (class, can’t use the hook, not sure where to send in the prop from)
  • getEmptyValue (tried sending the t in through params, but used in ArrayOfPrimitives which is a class)

@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 11, 2023 8:11pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 8:11pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 8:11pm

@RitaDias RitaDias changed the base branch from next to feat/i18n August 24, 2023 09:12
@RitaDias RitaDias force-pushed the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch from a0cd4fd to 9911fbb Compare August 24, 2023 10:42
@RitaDias RitaDias force-pushed the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch from 5552d51 to c3835cc Compare August 24, 2023 11:15
@RitaDias RitaDias force-pushed the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch 3 times, most recently from be1a628 to f6439ff Compare August 24, 2023 11:27
@rexxars rexxars changed the title Feature/sdx 608 convert array input actions strings to use i18n primitives feat(core): convert array input actions strings to use i18n primitives Aug 28, 2023
@rexxars rexxars force-pushed the feat/i18n branch 3 times, most recently from 0a5f428 to d687c89 Compare September 13, 2023 17:33
@rexxars rexxars force-pushed the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch from d4df160 to 4d02c2c Compare September 13, 2023 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Package Documentation Change
sanity +16%
@sanity/types +3%
sanity/desk +2%
Full Report
sanity
This branch Next branch
127 documented 110 documented
847 not documented 834 not documented
@sanity/types
This branch Next branch
47 documented 46 documented
240 not documented 240 not documented
sanity/desk
This branch Next branch
84 documented 83 documented
56 not documented 55 not documented
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
30 not documented 30 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
9 not documented 9 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
15 documented 15 documented
21 not documented 21 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Found an unused import that would be good to remove before merge.

@rexxars rexxars force-pushed the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch from 9cdd0fd to ff16352 Compare October 11, 2023 20:06
@rexxars rexxars merged commit d8635aa into feat/i18n Oct 11, 2023
12 checks passed
@rexxars rexxars deleted the feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives branch October 11, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants