-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): convert array input actions strings to use i18n primitives #4866
Merged
rexxars
merged 12 commits into
feat/i18n
from
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
Oct 11, 2023
Merged
feat(core): convert array input actions strings to use i18n primitives #4866
rexxars
merged 12 commits into
feat/i18n
from
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
RitaDias
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
August 24, 2023 10:42
a0cd4fd
to
9911fbb
Compare
RitaDias
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
August 24, 2023 11:15
5552d51
to
c3835cc
Compare
RitaDias
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
3 times, most recently
from
August 24, 2023 11:27
be1a628
to
f6439ff
Compare
rexxars
changed the title
Feature/sdx 608 convert array input actions strings to use i18n primitives
feat(core): convert array input actions strings to use i18n primitives
Aug 28, 2023
rexxars
force-pushed
the
feat/i18n
branch
3 times, most recently
from
September 13, 2023 17:33
0a5f428
to
d687c89
Compare
rexxars
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
September 13, 2023 20:38
d4df160
to
4d02c2c
Compare
Full Reportsanity
@sanity/types
sanity/desk
@sanity/diff
@sanity/block-tools
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
|
rexxars
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
October 5, 2023 04:26
e1b408f
to
a5aa116
Compare
rexxars
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
October 6, 2023 21:36
a5aa116
to
9cdd0fd
Compare
bjoerge
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Found an unused import that would be good to remove before merge.
packages/sanity/src/core/form/inputs/arrays/ArrayOfObjectsInput/Grid/IncompatibleItemType.tsx
Outdated
Show resolved
Hide resolved
…rimitivesFunctions
rexxars
force-pushed
the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
from
October 11, 2023 20:06
9cdd0fd
to
ff16352
Compare
rexxars
deleted the
feature/sdx-608-convert-array-input-actions-strings-to-use-i18n-primitives
branch
October 11, 2023 20:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert array input strings to use i18n primitives
TO DO still in PR:ArrayOfPrimitivesInputArrayOfPrimitivesInput (class, can’t use the hook, not sure where to send in the prop from)getEmptyValue (tried sending the t in through params, but used in ArrayOfPrimitives which is a class)