fix(PaneContainer): remove unsafe ref access during render

sanity-io · Dec 13, 2024 · 9411f1c · 9411f1c
1 parent 9d075f4
commit 9411f1c
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/packages/sanity/src/structure/panes/documentList/PaneContainer.tsx b/packages/sanity/src/structure/panes/documentList/PaneContainer.tsx
@@ -1,6 +1,6 @@
 import {Card, Code} from '@sanity/ui'
 import {isEqual} from 'lodash'
-import {memo, useMemo, useRef} from 'react'
+import {memo, useMemo, useState} from 'react'
 import {
   EMPTY_ARRAY,
   type GeneralDocumentListLayoutKey,
@@ -49,11 +49,12 @@ const addSelectedStateToMenuItems = (options: {
 }
 
 export function useShallowUnique<ValueType>(value: ValueType): ValueType {
-  const valueRef = useRef<ValueType>(value)
-  if (!shallowEquals(valueRef.current, value)) {
-    valueRef.current = value
+  const [current, setCurrent] = useState<ValueType>(value)
+  if (!shallowEquals(current, value)) {
+    setCurrent(value)
+    return value
   }
-  return valueRef.current
+  return current
 }
 
 /**