refactor: removing undefined return type from getTransLogs when no do…

…c IDs provided
sanity-io · Dec 13, 2024 · 5a2a17a · 5a2a17a
1 parent 44dedc7
commit 5a2a17a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/...releases/tool/components/releaseCTAButtons/ReleaseRevertButton/useDocumentRevertStates.ts b/...releases/tool/components/releaseCTAButtons/ReleaseRevertButton/useDocumentRevertStates.ts
@@ -1,7 +1,7 @@
 import {type SanityDocument} from '@sanity/types'
 import {useCallback, useEffect, useMemo, useRef} from 'react'
 import {useObservable} from 'react-rx'
-import {catchError, filter, forkJoin, from, map, type Observable, of, switchMap} from 'rxjs'
+import {catchError, forkJoin, from, map, type Observable, of, switchMap} from 'rxjs'
 
 import {useClient} from '../../../../../hooks/useClient'
 import {getTransactionsLogs} from '../../../../../store/translog/getTransactionLogs'
@@ -55,7 +55,6 @@ export const useDocumentRevertStates = (documents: DocumentInRelease[]) => {
         },
       ),
     ).pipe(
-      filter(Boolean),
       map((transactions) => {
         if (transactions.length === 0) throw new Error('No transactions found.')
 

diff --git a/...eases/tool/components/releaseCTAButtons/ReleaseRevertButton/usePostPublishTransactions.ts b/...eases/tool/components/releaseCTAButtons/ReleaseRevertButton/usePostPublishTransactions.ts
@@ -1,6 +1,6 @@
 import {useMemo} from 'react'
 import {useObservable} from 'react-rx'
-import {catchError, filter, from, map, of} from 'rxjs'
+import {catchError, from, map, of} from 'rxjs'
 
 import {useClient} from '../../../../../hooks/useClient'
 import {getTransactionsLogs} from '../../../../../store/translog/getTransactionLogs'
@@ -25,7 +25,6 @@ export const usePostPublishTransactions = (documents: DocumentInRelease[]) => {
         },
       ),
     ).pipe(
-      filter(Boolean),
       // the transaction of published is also returned
       // so post publish transactions will result in more than 1 transaction
       map((transactions) => transactions.length > 1),

diff --git a/packages/sanity/src/core/store/translog/getTransactionLogs.ts b/packages/sanity/src/core/store/translog/getTransactionLogs.ts
@@ -68,7 +68,7 @@ export async function getTransactionsLogs(
      */
     authors?: string
   },
-): Promise<TransactionLogEventWithEffects[] | undefined> {
+): Promise<TransactionLogEventWithEffects[]> {
   const clientConfig = client.config()
   const dataset = clientConfig.dataset
   const queryParams = new URLSearchParams({
@@ -90,8 +90,6 @@ export async function getTransactionsLogs(
     }?${queryParams.toString()}`,
   )
 
-  if (!documentIds.length) return undefined
-
   const stream = await getJsonStream(transactionsUrl, clientConfig.token)
   const transactions: TransactionLogEventWithEffects[] = []