refactor: memoizing result from usePerspective

sanity-io · Oct 28, 2024 · 367e123 · 367e123
1 parent 1c6133e
commit 367e123
Showing 1 changed file with 35 additions and 20 deletions.
diff --git a/packages/sanity/src/core/releases/hooks/usePerspective.tsx b/packages/sanity/src/core/releases/hooks/usePerspective.tsx
@@ -72,18 +72,23 @@ export function usePerspective(): PerspectiveValue {
       : LATEST
 
   // TODO: Improve naming; this may not be global.
-  const currentGlobalBundle =
-    perspective === 'published'
-      ? {
-          _id: 'published',
-          metadata: {
-            title: 'Published',
-          },
-        }
-      : selectedBundle || LATEST
-
-  const setPerspectiveFromRelease = (releaseId: string) =>
-    setPerspective(getBundleIdFromReleaseId(releaseId))
+  const currentGlobalBundle = useMemo(
+    () =>
+      perspective === 'published'
+        ? {
+            _id: 'published',
+            metadata: {
+              title: 'Published',
+            },
+          }
+        : selectedBundle || LATEST,
+    [perspective, selectedBundle],
+  )
+
+  const setPerspectiveFromRelease = useCallback(
+    (releaseId: string) => setPerspective(getBundleIdFromReleaseId(releaseId)),
+    [setPerspective],
+  )
 
   const bundlesPerspective = useMemo(
     () =>
@@ -123,12 +128,22 @@ export function usePerspective(): PerspectiveValue {
     [excludedPerspectives],
   )
 
-  return {
-    setPerspective,
-    setPerspectiveFromRelease,
-    toggleExcludedPerspective,
-    currentGlobalBundle: currentGlobalBundle,
-    bundlesPerspective,
-    isPerspectiveExcluded,
-  }
+  return useMemo(
+    () => ({
+      setPerspective,
+      setPerspectiveFromRelease,
+      toggleExcludedPerspective,
+      currentGlobalBundle,
+      bundlesPerspective,
+      isPerspectiveExcluded,
+    }),
+    [
+      bundlesPerspective,
+      currentGlobalBundle,
+      isPerspectiveExcluded,
+      setPerspective,
+      setPerspectiveFromRelease,
+      toggleExcludedPerspective,
+    ],
+  )
 }