chore(lint): add certain unicorn eslint rules

.eslintrc.cjs

@@ -33,6 +33,7 @@ const config = {
     'prettier',
     'react',
     'tsdoc',
+    'unicorn',
   ],
   ignorePatterns: [
     '**/etc/*',
@@ -182,6 +183,10 @@ const config = {
     'no-unused-vars': 'off',
     'no-useless-catch': 'warn',
     'no-async-promise-executor': 'warn',
+    'unicorn/prefer-string-slice': 'error',
+    'unicorn/prefer-node-protocol': 'error',
+    'unicorn/prefer-keyboard-event-key': 'error',
+    'unicorn/custom-error-definition': 'error',
   },
   settings: {
     'import/extensions': extensions,

package.json

@@ -130,6 +130,7 @@
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-simple-import-sort": "^12.0.0",
     "eslint-plugin-tsdoc": "^0.2.17",
+    "eslint-plugin-unicorn": "^52.0.0",
     "eslint-plugin-unused-imports": "^3.1.0",
     "execa": "^2.0.0",
     "glob": "^7.2.0",

packages/@sanity/block-tools/src/HtmlDeserializer/helpers.ts

@@ -161,18 +161,18 @@ export function trimWhitespace(blocks: TypedObject[]): TypedObject[] {
         child.text = child.text.replace(/[^\S\n]+$/g, '')
       }
       if (
-        /\s/.test(child.text.substring(child.text.length - 1)) &&
+        /\s/.test(child.text.slice(Math.max(0, child.text.length - 1))) &&
         nextChild &&
         isMinimalSpan(nextChild) &&
-        /\s/.test(nextChild.text.substring(0, 1))
+        /\s/.test(nextChild.text.slice(0, 1))
       ) {
         child.text = child.text.replace(/[^\S\n]+$/g, '')
       }
       if (
-        /\s/.test(child.text.substring(0, 1)) &&
+        /\s/.test(child.text.slice(0, 1)) &&
         prevChild &&
         isMinimalSpan(prevChild) &&
-        /\s/.test(prevChild.text.substring(prevChild.text.length - 1))
+        /\s/.test(prevChild.text.slice(Math.max(0, prevChild.text.length - 1)))
       ) {
         child.text = child.text.replace(/^[^\S\n]+/g, '')
       }

packages/@sanity/block-tools/src/util/randomKey.ts

@@ -9,7 +9,7 @@ function whatwgRNG(length = 16) {
 
 const byteToHex: string[] = []
 for (let i = 0; i < 256; ++i) {
-  byteToHex[i] = (i + 0x100).toString(16).substring(1)
+  byteToHex[i] = (i + 0x100).toString(16).slice(1)
 }
 
 /**

packages/@sanity/block-tools/test/tests/HtmlDeserializer/index.test.ts

@@ -1,8 +1,8 @@
-import * as fs from 'node:fs'
-import * as path from 'node:path'
+import assert from 'node:assert'
+import fs from 'node:fs'
+import path from 'node:path'
 
 import {describe, it} from '@jest/globals'
-import * as assert from 'assert'
 import {JSDOM} from 'jsdom'
 
 import * as blockTools from '../../../src'

packages/@sanity/block-tools/test/tests/util/normalizeBlock.test.ts

@@ -1,5 +1,6 @@
+import assert from 'node:assert'
+
 import {describe, it} from '@jest/globals'
-import * as assert from 'assert'
 
 import {normalizeBlock} from '../../../src/util/normalizeBlock'
 

packages/@sanity/schema/example/test.js

@@ -1,4 +1,4 @@
-import assert from 'assert'
+import assert from 'node:assert'
 
 import {Schema} from '../src/legacy/Schema'
 import schemaDef from './schema-def'

packages/@sanity/util/src/content/randomKey.ts

@@ -9,7 +9,7 @@ const getByteHexTable = (() => {
 
     table = []
     for (let i = 0; i < 256; ++i) {
-      table[i] = (i + 0x100).toString(16).substring(1)
+      table[i] = (i + 0x100).toString(16).slice(1)
     }
     return table
   }