test(playwright-ct): tweak timouts and meta key

sanity-io · Dec 11, 2024 · 042ba35 · 042ba35
1 parent b365756
commit 042ba35
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/packages/sanity/playwright-ct.config.ts b/packages/sanity/playwright-ct.config.ts
@@ -39,10 +39,10 @@ export default defineConfig({
       ],
 
   /* Maximum time one test can run for. */
-  timeout: 30 * 1000,
+  timeout: 60 * 1000,
   expect: {
     // Maximum time expect() should wait for the condition to be met.
-    timeout: 10 * 1000,
+    timeout: 40 * 1000,
   },
 
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */

diff --git a/packages/sanity/playwright-ct/tests/utils/testHelpers.tsx b/packages/sanity/playwright-ct/tests/utils/testHelpers.tsx
@@ -106,14 +106,15 @@ export function testHelpers({page}: {page: PlaywrightTestArgs['page']}) {
      * @returns The modifier key name ('Meta' for macOS, 'Control' for other platforms).
      */
     getModifierKey: (options?: {browserName?: string}) => {
-      if (process.platform === 'darwin') {
-        // There's a bug in Chromium on macOS where it use 'Control' instead of 'Meta' inside Playwright for some reason
-        if (options?.browserName && ['chromium', 'firefox'].includes(options.browserName)) {
-          return 'Control'
-        }
-        return 'Meta'
+      // There's a bug with Firefox and Chromium on macOS where it use 'Control' instead of 'Meta' inside Playwright for some reason
+      if (
+        process.platform === 'darwin' &&
+        options?.browserName &&
+        ['chromium', 'firefox'].includes(options.browserName)
+      ) {
+        return 'Control'
       }
-      return 'Control'
+      return 'ControlOrMeta'
     },
     /**
      * Types text with a delay using `page.keyboard.type`. Default delay emulates a human typing.