2369 graceful shutdown of signal handlers #2444
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
reviewed
May 24, 2022
| @@ -192,7 +192,7 @@ async def dispatch( | |||
| if inline: | |||
| return await dispatch | |||
|
|
|||
| task = asyncio.get_running_loop().create_task(dispatch) | |||
| task = asyncio.get_running_loop().create_task(dispatch, name="signal") | |||
There was a problem hiding this comment.
Do you think we should add a more descriptive name? Also include the handler __name__?
|
This does not seem to be working as intended. I am going to hold off on this until next release and try and come up with another solution. If you have other ides, LMK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2369
This PR makes two key changes:
asyncio.Tasks "signal" so that they are distinguishable from otherasyncio.Tasks that are running in the event loop.asyncio.Tasks when sanic is stopped.