Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-888 - Add page by page pagination #1124

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

BenTopping
Copy link
Collaborator

@BenTopping BenTopping commented Oct 5, 2023

Required for DPL-888 (UI add page by page pagination)

Changes proposed in this pull request

  • json api resources return page count in response meta
  • Adds experiment_name and state filters to ONT run resource

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1124 (da485d9) into develop (3a3a990) will increase coverage by 0.07%.
Report is 35 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1124      +/-   ##
===========================================
+ Coverage    97.61%   97.68%   +0.07%     
===========================================
  Files          366      372       +6     
  Lines        10597    11380     +783     
===========================================
+ Hits         10344    11117     +773     
- Misses         253      263      +10     
Files Coverage Δ
app/resources/v1/ont/run_resource.rb 100.00% <100.00%> (ø)
config/initializers/jsonapi_resources.rb 100.00% <100.00%> (ø)
spec/requests/v1/ont/runs_spec.rb 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BenTopping BenTopping requested a review from stevieing October 6, 2023 14:21
@BenTopping BenTopping marked this pull request as ready for review October 6, 2023 14:21
@stevieing stevieing merged commit 7734a37 into develop Oct 23, 2023
@stevieing stevieing deleted the DPL-888-page-by-page-pagination branch November 21, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants