Y24-190: Support v2 searches #4616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to add tests of and_submit as well as malformed payloads
Make some of the logic exist in the resource and don't gather errors in an array when they can be raised immediately
Y24-190: Support Limber with Qcable on API v2
Y24-190: Refactor JSONAPI::Resources Processors
…ompletions Y24-190: Add V2 endpoint for creating and reading WorkCompletions
…sions Y24-190: Support Limber with Submission creation
# Conflicts: # app/controllers/api/v2/tag_layouts_controller.rb
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4616 +/- ##
===========================================
+ Coverage 89.31% 89.54% +0.23%
===========================================
Files 1406 1410 +4
Lines 30053 30863 +810
===========================================
+ Hits 26842 27637 +795
- Misses 3211 3226 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4615
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version