Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-429 [PR] update feature flag and warning message #4612

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

yoldas
Copy link
Member

@yoldas yoldas commented Jan 16, 2025

Closes #

Changes proposed in this pull request

  • Remove the feature flag to always enable the cDNA Prep feasibility validations.
  • Reword the warning message to say that the requested values would not give them enough material for 2 repeat pooling attempts rather than 'full allowance'. This will just be a bit clearer to the SSR what this means.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (49baaf3) to head (e0495b5).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4612      +/-   ##
===========================================
+ Coverage    89.40%   89.43%   +0.03%     
===========================================
  Files         1407     1407              
  Lines        30332    30331       -1     
===========================================
+ Hits         27117    27126       +9     
+ Misses        3215     3205      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoldas yoldas merged commit a4cd392 into develop Jan 16, 2025
27 checks passed
@yoldas yoldas deleted the y24-429-update-feature-flag-and-warning-message branch January 16, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants