Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24 102 tube rack banking bed verification #4611

Open
wants to merge 7 commits into
base: y24-088-tuberacks-epic
Choose a base branch
from

Conversation

andrewsparkes
Copy link
Member

No description provided.

@andrewsparkes andrewsparkes self-assigned this Jan 16, 2025
@andrewsparkes andrewsparkes linked an issue Jan 16, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 96.72489% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (8eb2269) to head (46b5a98).

Files with missing lines Patch % Lines
...sion/scrna_core_cdna_prep_feasibility_validator.rb 94.69% 6 Missing ⚠️
app/models/tube_rack.rb 66.66% 5 Missing ⚠️
.../models/submission/validations_by_template_name.rb 97.01% 2 Missing ⚠️
...ion/scrna_core_cdna_prep_feasibility_calculator.rb 93.33% 1 Missing ⚠️
app/models/well.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           y24-088-tuberacks-epic    #4611      +/-   ##
==========================================================
- Coverage                   89.32%   89.32%   -0.01%     
==========================================================
  Files                        1411     1412       +1     
  Lines                       30278    30521     +243     
==========================================================
+ Hits                        27046    27263     +217     
- Misses                       3232     3258      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (e65234a) to head (32c656e).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           y24-088-tuberacks-epic    #4611      +/-   ##
==========================================================
+ Coverage                   89.42%   89.48%   +0.05%     
==========================================================
  Files                        1412     1412              
  Lines                       30503    30521      +18     
==========================================================
+ Hits                        27278    27312      +34     
+ Misses                       3225     3209      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yoldas yoldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-102 Tube Rack Banking Bed verification
2 participants