-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding the requested new plate purpose #4593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in edit form to fail validation by default when editing an old study
…val of valid default values
…delay approval study metadata
…o y24-481-study-setup-page
removing outdated code responsible for creating links between the source plate and the target purpose plate
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4593 +/- ##
===========================================
- Coverage 89.31% 89.24% -0.08%
===========================================
Files 1406 1406
Lines 30053 30051 -2
===========================================
- Hits 26842 26819 -23
- Misses 3211 3232 +21 ☔ View full report in Codecov by Sentry. |
KatyTaylor
reviewed
Jan 13, 2025
removing outdated code responsible for creating links between the source plate and the target purpose plate
KatyTaylor
approved these changes
Jan 13, 2025
…o y24-481-study-setup-page
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NANOID-8492085
[js] Update sortablejs 1.15.2 → 1.15.6 (patch)
…data, removes redundant fields
…4c99ed07b [Snyk] Security upgrade postcss from 8.4.49 to 8.5.0
…record-4.1.11 [ruby] Update delayed_job_active_record 4.1.8 → 4.1.11 (patch)
[ruby] Update ruby-units 4.0.3 → 4.1.0 (minor)
Y24-481 - Study setup page changes
removing outdated code responsible for creating links between the source plate and the target purpose plate
removing outdated code responsible for creating links between the source plate and the target purpose plate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding the requested new plate purpose
removing outdated code responsible for creating links between the source plate and the target purpose plate
Integration tests:
https://gitlab.internal.sanger.ac.uk/psd/integration-suite/-/merge_requests/209