-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP DO NOT MERGE - Y24-088 tuberacks epic into develop #4568
Open
andrewsparkes
wants to merge
50
commits into
develop
Choose a base branch
from
y24-088-tuberacks-epic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y24-098 - Tube rack banking purpose
… endpoint, and added tube rack purpose to v2 api
…sequencescape-api
…, was returning nil for request type
…types of labwares
# Conflicts: # db/schema.rb
…rather than pass from Limber
…sequencescape-api
…cescape-api Y24-099 scRNA - tube rack banking sequencescape api
…ape into y24-088-tuberacks-epic
2 tasks
… and added method comments
…labels Y24 103 tuberack presenter tube labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4568 +/- ##
===========================================
- Coverage 89.42% 89.42% -0.01%
===========================================
Files 1407 1412 +5
Lines 30331 30503 +172
===========================================
+ Hits 27125 27278 +153
- Misses 3206 3225 +19 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version