Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop -> Master #4339

Merged
merged 241 commits into from
Sep 17, 2024
Merged

Develop -> Master #4339

merged 241 commits into from
Sep 17, 2024

Conversation

BenTopping
Copy link
Contributor

@BenTopping BenTopping commented Sep 12, 2024 •
edited
Loading

Changes proposed in this pull request

  • Y24-190 - API v2 milestone 1 work. Adds new/updated API v2 endpoints for:
    • BarcodePrinter
    • CustomMetadatumCollection
    • StateChange
    • TagLayoutTemplate
    • Transfer
    • TransferTemplate
  • Y24-221 - Sequencescape TagSet pages.
  • Y24-055 - New plate manifest type for dual index tags.
  • Y24-087 - LabWhere Reception error message improvements.
  • DPL-1104 - New RVI BCL submission template with NovaSeq 6000 requests.
  • Y24-064 - Retention instruction audit mechanism.
  • Y24-172 - Feature flag changes.
  • BUG fix - Precompile assets docker flag.
  • Various dependency updates

sdjmchattie and others added 30 commits July 22, 2024 18:16
@sdjmchattie
Add a resource for BarcodePrinters on v2 API
fd3a078
@sdjmchattie
Rename type_name to barcode_type
d40d80b
@sdjmchattie
Add print_service attribute to BarcodePrinter
3c61436
@sdjmchattie
Add tests for barcode printers on V2
627b1b1
@sdjmchattie
Clean up implementation of CustomMetadatumCollection
a39e2a3
@sdjmchattie
Separate expectations into different test cases
8c7d622
@sdjmchattie
Capture the expectation before applying the failing method
4f653cd
@sdjmchattie
Fix the devour tasks
6466af5 
They were failing when they found Concerns and SharedBehaviour sub modules which did not contain JSONAPI::Resource implementations.
@sdjmchattie
Extract immutable array from loop
aa42dc7 
Presumably for efficiency, which we shouldn't be concerned about here, but Rubocop insists!
@sdjmchattie
Merge pull request #4225 from sanger/Y24-190-2-add-barcode-printers-t…
babbbcc 
…o-v2-api

Y24-190-2: Add barcode printers to v2 API
@BenTopping
feat: adds novaseq 6000 sequencing request to rvi bcl submission
0ee7ea9
@BenTopping
style: linted
3993807
@sdjmchattie
Update TagLayoutTemplate resource with YARD docs
8f66d79
@sdjmchattie
Merge branch 'develop' into develop-Y24-190
fe8663e
@sdjmchattie
Assign correct class name for tag2_group
118fedd
@sdjmchattie
Improve test coverage of a TagLayoutTemplateResource
db19247
@sdjmchattie
Improve class documentation for TagLayoutTemplate
b11d920
@sdjmchattie
Merge branch 'develop' into develop-Y24-190
347ad0f
@sdjmchattie
Merge branch 'develop-Y24-190' into Y24-190-3-support-limber-labware-…
4afe887 
…creators-in-api-v2
@sdjmchattie
Tweak YARD documentation options
9daa2d0
@sdjmchattie
Add immutability as a note on the class
96b13dc
@sdjmchattie
Move #post outside the context
6ec2a17 
The context is setting up a CustomMetadatumCollection, but we don't need one to be able to #post.
@sdjmchattie
Improve request tests for TagLayoutTemplates
a029dd4
@sdjmchattie
Exclude API controllers from documentation
685fc92
@sdjmchattie
Tag resources of the V2 API
d453719
@sdjmchattie
Complete documentation for TagLayoutTemplateResource
f91fe71
@sdjmchattie
Fix grammar in immutability note
0d038d1
@sdjmchattie
Merge pull request #4258 from sanger/Y24-190-3-support-limber-labware…
6904687 
…-creators-in-api-v2

Y24-190-3: Support Limber TagLayoutTemplate in API v2
@sdjmchattie
Add detailed overviews for each resource class.
6f24ac3 
These contain TODOs for things which are going to require knowledge of the Sequencescape models.
@sdjmchattie
Remove double-blank line upsetting Prettier
975c986
harrietc52 and others added 13 commits September 9, 2024 13:07
@harrietc52
remove y24-055 todo file
78194d2
@harrietc52
Merge branch 'develop' into y24-055-2
62d6944
@BenTopping
Merge pull request #4326 from sanger/Y24-087-labware-reception-bug-fix
795a6e4 
Y24-087 - Error messages for labwhere reception
@BenTopping
ci: bumps upload artifact action
2d8ebc8
@BenTopping
Merge pull request #4332 from sanger/bump-upload-artifact-action
1fdca0a 
CI Fix - Bumps upload artifact action
@BenTopping
Merge branch 'develop' of https://github.com/sanger/sequencescape int…
75dde7f 
…o y24-055-2
@BenTopping
misc: rename of dual index manifest type heading and change of dropdo…
55022bd 
…wn order
@BenTopping
Merge pull request #4331 from sanger/y24-055-2
ecbdee7 
Y24-055 Take 2
@BenTopping
misc(dual-index-tags): removes wip file extension from dual index tag…
cbf334f 
… groups and sets
@BenTopping
Merge pull request #4336 from sanger/un-wip-tag-sets
c84a705 
Y24-221 - Un wip tag groups and tag sets
@SHIV5T3R
Set vite build target to chrome65
3013654
@SHIV5T3R
Added es2019 (current default) to build targets
939009c
@sabrine33
Merge pull request #4324 from sanger/Y24-111-flowcell-type-field
51e3d5e 
Y24 111 - Add a required constraint to the flowcell type field for NovaSeq requests.
@BenTopping
Copy link
Contributor Author

I will bump release version once the contents of the PR are confirmed to be ready to go out to prod.

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.63%. Comparing base (3ce0d5e) to head (0ecbb5a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/tasks/devour.rake 0.00% 5 Missing ⚠️
...pp/resources/api/v2/transfers/transfer_resource.rb 98.48% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
+ Coverage   87.48%   87.63%   +0.14%     
==========================================
  Files        1375     1383       +8     
  Lines       29669    29890     +221     
==========================================
+ Hits        25957    26194     +237     
+ Misses       3712     3696      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenTopping BenTopping merged commit d6442a0 into master Sep 17, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrine33 sabrine33 sabrine33 approved these changes

@StephenHulme StephenHulme StephenHulme approved these changes

@sdjmchattie sdjmchattie sdjmchattie approved these changes

@wendyyang wendyyang Awaiting requested review from wendyyang

@dasunpubudumal dasunpubudumal Awaiting requested review from dasunpubudumal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@BenTopping @sdjmchattie @StephenHulme @sabrine33 @wendyyang @harrietc52 @SHIV5T3R @dasunpubudumal @yoldas