Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-102 Tube Rack Banking Bed verification #1699

Open
2 tasks done
yoldas opened this issue May 20, 2024 · 3 comments · May be fixed by #2156 or sanger/sequencescape#4611
Open
2 tasks done

Y24-102 Tube Rack Banking Bed verification #1699

yoldas opened this issue May 20, 2024 · 3 comments · May be fixed by #2156 or sanger/sequencescape#4611
Assignees
Labels

Comments

@yoldas
Copy link
Member

yoldas commented May 20, 2024

User story
As PSD, we would like to support bed verification using the versioned tube rack model proposed in Reuse of TubeRacks document. LRC Bank Seq and LRC Bank Spare tube racks are destination labware in this bed verification.

Who are the primary contacts for this story
Abdullah, Katy, Andrew

Who is the nominated tester for UAT
Once Y24-088 and its dependencies are complete, we can ask Abby if she will UAT it. Could send some screenshots for earlier feedback.

Acceptance criteria
To be considered successful the solution must allow:

  • DPL-829 acceptance criteria using the TubeRack model, retiring the TubeRackWrapper implementation.
  • Update the integration suite tests if necessary.

It is not possible to release the implementation of this story in isolation. There are epic branches in use for SS, Limber and Int Suite to branch from and to.

Dependencies
Story relationships are shown in the Lucidchart diagram TubeRack Stories .

Additional context
The existing bed verification for scRNA Core uses a wrapper to represent Tube Racks in bed verification stage. See DPL-829. It queries the parent's downstream tubes to find out which tubes are on the tube rack. It transforms the given robot configuration to support optional tube racks. See app/models/robots/plate_to_tube_racks_robot.rb

The versioned tube rack model is researched in DPL-1011 and the model is summarised in the Google Document DPL-1011 Re-use of tube racks

This story is part of re-implementation of DPL-811 Transfer PBMC isolations into FluidX tube racks (Banking) using the versioned tube rack model.

@yoldas yoldas changed the title Y24-092 Tube Rack Banking Bed verification Y24-084 Tube Rack Banking Bed verification May 20, 2024
@TWJW-SANGER
Copy link

Apologies, I'm a little confused on the validation "Additional validation of parent's downstream tubes against tube racks' tubes."
Are we checking that the set of tubes transferred on to the destination tube rack/s came from the source tube rack/s ? Or is it a bit different?

@yoldas yoldas changed the title Y24-084 Tube Rack Banking Bed verification Y24-102 Tube Rack Banking Bed verification May 21, 2024
@yoldas
Copy link
Member Author

yoldas commented May 24, 2024

@TWJW-SANGER It was a left-over check from the existing implementation. I have removed that from the criteria because we already established the parent LRC PBMC Bank plate and LRC Bank Seq and LRC Bank Spare TubeRacks relationships.

In the existing DPL-829, we had to find descendant tubes of LRC PBMC Bank plate, check their metadata to find their tuberack barcode, group and wrap them in TubeRackWrappers by purpose and last versions and verify the entered tuberack barcodes (multiple beds). We don't need to do those anymore.

@KatyTaylor
Copy link
Contributor

Edited the story description to include links and remove clutter.

@andrewsparkes andrewsparkes self-assigned this Jan 8, 2025
@andrewsparkes andrewsparkes linked a pull request Jan 13, 2025 that will close this issue
@andrewsparkes andrewsparkes added Size: M Medium - medium effort & risk and removed Size: S Small - low effort & risk labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants