Add presence validation to tube_purpose_name in the generate sample m…

…anifest uat action
sanger · Jan 16, 2025 · 9e2777b · 9e2777b
1 parent 705af56
commit 9e2777b
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/app/uat_actions/uat_actions/generate_sample_manifest.rb b/app/uat_actions/uat_actions/generate_sample_manifest.rb
@@ -43,6 +43,7 @@ class UatActions::GenerateSampleManifest < UatActions
 
   form_field :with_samples, :check_box, help: 'Create new samples for recipients?', label: 'With Samples?'
 
+  validates :tube_purpose_name, presence: true
   validate :validate_tube_purpose_exists
 
   def self.default
@@ -67,7 +68,7 @@ def perform
   #
   # @return [void]
   def validate_tube_purpose_exists
-    return if tube_purpose_name.blank? # Uses the default.
+    return if tube_purpose_name.blank? # Already validated by presence
     return if Tube::Purpose.exists?(name: tube_purpose_name)
 
     message = format(ERROR_TUBE_PURPOSE_DOES_NOT_EXIST, tube_purpose_name)