-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release] Merge Develop into Master #2117
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when preparing transfer_requests_attributes
spec/features/pooling_multiple_tubes_into_one_tube_spec.rb spec/models/labware_creators/donor_pooling_plate_spec.rb spec/models/labware_creators/plate_split_to_tube_racks_spec.rb spec/models/labware_creators/pooled_wells_by_sample_in_groups_spec.rb
with calls to the helper function
over to common helper methods
to be fair, this was a good suggestion!
Y24-190: Use api v2 plate everywhere
Clear unneeded v1 mocks out of tests
…on-with-a-template Y24-190: Use v2 tag layout creation with a template
…-plates Y24-051: Hide pools tab for stock plates
…ab-for-stock-plates Revert "Y24-051: Hide pools tab for stock plates"
This allows us to get the stock_plate and its attributes without making requests repeatedly over the API
API v2 Milestone 3
StephenHulme
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good 🚀
andrewsparkes
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Instructions for Reviewers
Everything above the horizontal rule will be overwritten on the next push
This PR was auto-generated on 2024-12-11T11:02:05+00:00
Additional Context
Switches Sequencescape API usage over to v2 for the following endpoints:
bulk_transfers
plates
plate_conversions
plate_creations
qc_files
submission_pools
transfer_request_collections
transfers
tubes
tube_from_tube_creations