Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Merge Develop into Master #2117

Merged
merged 147 commits into from
Dec 11, 2024
Merged

[release] Merge Develop into Master #2117

merged 147 commits into from
Dec 11, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 10, 2024

Proposed Changes

Instructions for Reviewers

  • Check stories are ready for release.
  • Check for any database migrations.
  • Check for debug code.
  • Check version is appropriate.

Everything above the horizontal rule will be overwritten on the next push
This PR was auto-generated on 2024-12-11T11:02:05+00:00


Additional Context

Switches Sequencescape API usage over to v2 for the following endpoints:

  • bulk_transfers
  • plates
  • plate_conversions
  • plate_creations
  • qc_files
  • submission_pools
  • transfer_request_collections
  • transfers
  • tubes
  • tube_from_tube_creations

when preparing transfer_requests_attributes
spec/features/pooling_multiple_tubes_into_one_tube_spec.rb
spec/models/labware_creators/donor_pooling_plate_spec.rb
spec/models/labware_creators/plate_split_to_tube_racks_spec.rb
spec/models/labware_creators/pooled_wells_by_sample_in_groups_spec.rb
to be fair, this was a good suggestion!
sdjmchattie and others added 23 commits November 21, 2024 19:50
…on-with-a-template

Y24-190: Use v2 tag layout creation with a template
…-plates

Y24-051: Hide pools tab for stock plates
…ab-for-stock-plates

Revert "Y24-051: Hide pools tab for stock plates"
This allows us to get the stock_plate and its attributes without making requests repeatedly over the API
@sdjmchattie sdjmchattie self-assigned this Dec 11, 2024
@sdjmchattie sdjmchattie marked this pull request as ready for review December 11, 2024 11:02
Copy link
Contributor

@StephenHulme StephenHulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good 🚀

@sdjmchattie sdjmchattie merged commit 23a1b9e into master Dec 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants