Y24-486: Add relatives tab #2114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be populated with whatever is assigned to parents and children
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## y24-088-tuberacks-epic #2114 +/- ##
==========================================================
- Coverage 80.78% 80.67% -0.11%
==========================================================
Files 482 482
Lines 18295 18296 +1
Branches 269 268 -1
==========================================================
- Hits 14780 14761 -19
- Misses 3513 3533 +20
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yoldas
approved these changes
Jan 6, 2025
| <li class="nav-item"> | ||
| <% data_attributes = { | ||
| sequencescape_api: Limber::Application.config.api.v2.connection_options.js_url, | ||
| sequencescape_api_key: Limber::Application.config.api.v2.connection_options.authorisation, |
There was a problem hiding this comment.
It is not specific to this PR but we are including the key in page sources. Maybe we can discuss if there is any alternative to this.
| @@ -35,6 +35,7 @@ def model_name | |||
| has_many :tubes, through: :racked_tubes, class_name: 'Sequencescape::Api::V2::Tube' | |||
|
|
|||
| has_many :parents, class_name: 'Sequencescape::Api::V2::Asset' | |||
| has_many :children, class_name: 'Sequencescape::Api::V2::Asset' | |||
There was a problem hiding this comment.
check the SS side, in case I removed the relationship there?
There was a problem hiding this comment.
yeah it's not there, just parents
same with descendants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2097
Changes proposed in this pull request
data_attributesto within the list-item it relates toScreenshot
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version