Y24-486: Add relatives tab #2114
Conversation
It will be populated with whatever is assigned to parents and children
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## y24-088-tuberacks-epic #2114 +/- ##
==========================================================
- Coverage 80.78% 80.67% -0.11%
==========================================================
Files 482 482
Lines 18295 18296 +1
Branches 269 268 -1
==========================================================
- Hits 14780 14761 -19
- Misses 3513 3533 +20
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| <li class="nav-item"> | ||
| <% data_attributes = { | ||
| sequencescape_api: Limber::Application.config.api.v2.connection_options.js_url, | ||
| sequencescape_api_key: Limber::Application.config.api.v2.connection_options.authorisation, |
There was a problem hiding this comment.
It is not specific to this PR but we are including the key in page sources. Maybe we can discuss if there is any alternative to this.
There was a problem hiding this comment.
Probably, I see that it is in a few places. I agree out of scope for this PR, but would be nice to be addressed.
| @@ -35,6 +35,7 @@ def model_name | |||
| has_many :tubes, through: :racked_tubes, class_name: 'Sequencescape::Api::V2::Tube' | |||
|
|
|||
| has_many :parents, class_name: 'Sequencescape::Api::V2::Asset' | |||
| has_many :children, class_name: 'Sequencescape::Api::V2::Asset' | |||
There was a problem hiding this comment.
check the SS side, in case I removed the relationship there?
There was a problem hiding this comment.
yeah it's not there, just parents
same with descendants
There was a problem hiding this comment.
As there are currently no children (and what children means is still undefined) this doesn't affect operation.
children in this file could alternatively be aliased to racked_tubes (and required attributes delegated) to show the child tubes. Either way, this is better scoped in a separate PR.
Closes #2097
Changes proposed in this pull request
data_attributesto within the list-item it relates toScreenshot
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version