Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend startup join domain to linux #197

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nblair2
Copy link
Contributor

@nblair2 nblair2 commented Nov 13, 2024

This adds the ability for linux hosts to join MS Active Directory domains using realmd (assumed to be already installed).

Some light refactoring of when we check for the startup app to do it once before all hosts, now that it is needed for both linux and windows boxes.

This adds the ability for linux hosts to join MS Active Directory domains using the realmd package.

Some light refactoring of when/where we check for the startup app to do it once before all hosts.
@nblair2 nblair2 marked this pull request as ready for review November 13, 2024 01:58
@nblair2
Copy link
Contributor Author

nblair2 commented Nov 18, 2024

@activeshadow or @glattercj can you take a look? Might be a layer 8 issue but I can't add assignees / reviewers.

@activeshadow
Copy link
Collaborator

@nblair2 I'll try to take a look ASAP.

@nblair2
Copy link
Contributor Author

nblair2 commented Nov 18, 2024

@activeshadow no rush just want to make sure this is marked ready for someone with merge access whenever they get to it.

Copy link
Collaborator

@glattercj glattercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants