Adds detection for Glory Star and improves detection for Android (mat…

…omo-org#7767) * Improves version detection for Android * Adds detection for Glory Star
sanchezzzhak · Aug 8, 2024 · 9ca2b42 · 9ca2b42
1 parent 4729129
commit 9ca2b42
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 1 deletion.
diff --git a/Parser/Device/AbstractDeviceParser.php b/Parser/Device/AbstractDeviceParser.php
@@ -665,6 +665,7 @@ abstract class AbstractDeviceParser extends AbstractParser
         'GLB' => 'Globmall',
         '38'  => 'GLONYX',
         'U6'  => 'Glofiish',
+        'GLO' => 'Glory Star',
         'G7'  => 'GoGEN',
         'GC'  => 'GOCLEVER',
         '5G'  => 'Gocomma',

diff --git a/Tests/Parser/fixtures/oss.yml b/Tests/Parser/fixtures/oss.yml
@@ -5158,3 +5158,11 @@
     version: ""
     platform: ""
     family: GNU/Linux
+-
+  user_agent: Mozilla/5.0 (Linux; StarOS 9) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Focus/4.7.2 Chrome/91.0.4472.77 Mobile Safari/537.36
+  os:
+    name: Android
+    short_name: AND
+    version: "9"
+    platform: ""
+    family: Android
diff --git a/Tests/fixtures/tablet-11.yml b/Tests/fixtures/tablet-11.yml
@@ -8325,3 +8325,21 @@
     model: MiTraveler 958
   os_family: Android
   browser_family: Chrome
+-
+  user_agent: Mozilla/5.0 (Linux; StarOS 9) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Focus/4.7.2 Chrome/91.0.4472.77 Mobile Safari/537.36
+  os:
+    name: Android
+    version: "9"
+    platform: ""
+  client:
+    type: browser
+    name: Firefox Focus
+    version: 4.7.2
+    engine: Blink
+    engine_version: 91.0.4472.77
+  device:
+    type: tablet
+    brand: Glory Star
+    model: ""
+  os_family: Android
+  browser_family: Unknown
diff --git a/regexes/device/mobiles.yml b/regexes/device/mobiles.yml
@@ -36734,6 +36734,12 @@ Glofiish:
       device: 'tablet'
       model: 'G Pad Air'
 
+# Glory Star (https://www.glorystartouch.com/)
+Glory Star:
+  regex: 'StarOS'
+  device: 'tablet'
+  model: ''
+
 # Polar (polar.ru)
 Polar:
   regex: 'Polar(?:_W?K?)?[_ ]P\d{2}|(?:P42L31T2CSM|P32L33T2CSM)(?:[);/ ]|$)'

diff --git a/regexes/oss.yml b/regexes/oss.yml
@@ -759,7 +759,7 @@
   name: 'Android'
   version: ''
 
-- regex: '(?:Android OS|OMDroid|sdk_gphone64_arm64-userdebug)[ /](\d+[\.\d]*)'
+- regex: '(?:Android OS|OMDroid|sdk_gphone64_arm64-userdebug|StarOS)[ /](\d+[\.\d]*)'
   name: 'Android'
   version: '$1'