Enable codeclimate and refactor rubocop config #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
changed the title
Co-authored-by: phuongdh <[email protected]>
cjcolvar
changed the title
Co-authored-by: phuongdh <[email protected]>
This was referenced Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the rubocop config should go into
.rubocop.exceptions.ymlsince it will be inherited in both the default and codeclimate config files.I opened a ticket in bixby to figure out how to better support this use case with
inherit_fromusing a URI. That would simplify the code climate config and maybe could help us unify the rubocop configs so we don't need a separate one for code climate.samvera/bixby#27