Convert U to T instead of U to N when sam_parsing. #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this changes seq_nt16_table it changes it for all other uses of this lookup table too, which will be widespread. However this feels like a reasonable thing to do given it only has an impact on data which is currently out of bounds of what is expected. Fixes samtools/samtools#2131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this changes seq_nt16_table it changes it for all other uses of this lookup table too, which will be widespread. However this feels like a reasonable thing to do given it only has an impact on data which is currently out of bounds of what is expected.
Fixes samtools/samtools#2131