Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue created in PR#1848 #1849

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Commits on Oct 16, 2024

  1. Fix issue created in PR#1848

    We shouldn't be attempting to create embedded reference sequences for
    CRAM containers with reads mapped to chr -1 (ie unmapped).  We don't
    permit embed_ref in multi-ref mode and it's nonsensical for entirely
    unmapped data.
    
    The only real fix needed here is "c->ref_id < 0" just before
    calling cram_generate_reference(), but checking elsewhere can sidestep
    other potential issues and we have safety in checking in more than one
    place.
    
    Credit to OSS_Fuzz
    Fixes oss-fuzz issue 372547397
    jkbonfield committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4c1acb8 View commit details
    Browse the repository at this point in the history