-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cpu_collect compatible with OSX and use gstdbuf #7
base: master
Are you sure you want to change the base?
Conversation
This fixed the issue for me. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this.
Will this pr be merged? |
And then CPU outputs ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please merge this one.
@samoshkin please merge this |
@samoshkin please consider merging this. Currently I (and probably many others) have resorted to using aaronlna/tmux-plugin-sysstat but it'd be nice to use the main project. |
#5
Environment
Problems
iostat
intervals are buffered-- even while usingstdbuf
-- until all intervals are complete. This makes thecpu_collect
script not update the statusline for TMUX as a refresh happens before all intervals are completed (ie. nothing gets written to the corresponding tmp file).Changes
g
prefixedgstdbuf
on OSX as to not require modifying the user PATH.iostat
per TMUX status line refresh.