Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-integration: Remove group installation of development tools #29

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Aug 1, 2023

We explicitly install vagrant-libvirt and no longer perform internal installation using vargant command line.

depends on #26

@dpulls
Copy link

dpulls bot commented Aug 1, 2023

🎉 All dependencies have been resolved !

Copy link
Contributor

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

We explicitly install vagrant-libvirt and no longer perform internal
installation using `vargant` command line.
Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@anoopcs9 anoopcs9 merged commit 7936189 into samba-in-kubernetes:main Aug 3, 2023
2 checks passed
@anoopcs9 anoopcs9 deleted the rm-dev-grp-install branch August 3, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants