Merge dockerfiles #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave992
force-pushed
the
single_dockerfile_with_stages
branch
from
d782fe9 to
83203d2
Compare
lqnnguyen
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For another project, we wanted to use the docker image with the SDK already installed. I noticed we now had 2 dockerfiles, where the
.devversion did not take into account the.civersion and also installed ROS from scratch.I simplified the docker files into a single multi-staged build. All stages (core, base, dev) have been pushed to the registry.
I pointed the docker compose to the Dockerfile, but you likely want to point this to the registry instead to prevent it rebuilding the image again and again. Long term we can let the CI build the image and push it to the registry.
@nikhil-sethi @lqnnguyen can you pick this PR up / review it?