Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plasma-infra: Migrate to Storybook 7 [B2C] #847

Merged
merged 6 commits into from
Nov 14, 2023
Merged

plasma-infra: Migrate to Storybook 7 [B2C] #847

merged 6 commits into from
Nov 14, 2023

Conversation

Yakutoc
Copy link
Collaborator

@Yakutoc Yakutoc commented Nov 14, 2023

Release Notes

Переход на Storybook@latest(7.5.3):

What/why Changed

From version 6.5.x to 7.0.0

Audit vulnerabilities

After:

Screenshot 2023-11-16 at 11 47 52
🐤 Download canary assets:
borderRadius
borderRadius_default_react-native--canary.847.6861938533.ts
borderRadius_plasma_b2c_react-native--canary.847.6861938533.ts
borderRadius_plasma_web_react-native--canary.847.6861938533.ts
borderRadius_sberHealth_react-native--canary.847.6861938533.ts
borderRadius_sbermarket_business_react-native--canary.847.6861938533.ts
borderRadius_sbermarket_metro_react-native--canary.847.6861938533.ts
borderRadius_sbermarket_react-native--canary.847.6861938533.ts
borderRadius_sbermarket_selgros_react-native--canary.847.6861938533.ts
borderRadius_sbermarket_wlbusiness_react-native--canary.847.6861938533.ts
borderRadius_sberonline_react-native--canary.847.6861938533.ts
borderRadius_sberprime_react-native--canary.847.6861938533.ts
borderRadius_stylesSalute_react-native--canary.847.6861938533.ts
color
color_default_ios-swift--canary.847.6861938533.swift
color_default_kotlin--canary.847.6861938533.kt
color_default_react-native--canary.847.6861938533.ts
color_default_xml--canary.847.6861938533.xml
color_plasma_b2c_ios-swift--canary.847.6861938533.swift
color_plasma_b2c_kotlin--canary.847.6861938533.kt
color_plasma_b2c_react-native--canary.847.6861938533.ts
color_plasma_b2c_xml--canary.847.6861938533.xml
color_plasma_web_ios-swift--canary.847.6861938533.swift
color_plasma_web_kotlin--canary.847.6861938533.kt
color_plasma_web_react-native--canary.847.6861938533.ts
color_plasma_web_xml--canary.847.6861938533.xml
color_sberHealth_ios-swift--canary.847.6861938533.swift
color_sberHealth_kotlin--canary.847.6861938533.kt
color_sberHealth_react-native--canary.847.6861938533.ts
color_sberHealth_xml--canary.847.6861938533.xml
color_sbermarket_business_ios-swift--canary.847.6861938533.swift
color_sbermarket_business_kotlin--canary.847.6861938533.kt
color_sbermarket_business_react-native--canary.847.6861938533.ts
color_sbermarket_business_xml--canary.847.6861938533.xml
color_sbermarket_ios-swift--canary.847.6861938533.swift
color_sbermarket_kotlin--canary.847.6861938533.kt
color_sbermarket_metro_ios-swift--canary.847.6861938533.swift
color_sbermarket_metro_kotlin--canary.847.6861938533.kt
color_sbermarket_metro_react-native--canary.847.6861938533.ts
color_sbermarket_metro_xml--canary.847.6861938533.xml
color_sbermarket_react-native--canary.847.6861938533.ts
color_sbermarket_selgros_ios-swift--canary.847.6861938533.swift
color_sbermarket_selgros_kotlin--canary.847.6861938533.kt
color_sbermarket_selgros_react-native--canary.847.6861938533.ts
color_sbermarket_selgros_xml--canary.847.6861938533.xml
color_sbermarket_wlbusiness_ios-swift--canary.847.6861938533.swift
color_sbermarket_wlbusiness_kotlin--canary.847.6861938533.kt
color_sbermarket_wlbusiness_react-native--canary.847.6861938533.ts
color_sbermarket_wlbusiness_xml--canary.847.6861938533.xml
color_sbermarket_xml--canary.847.6861938533.xml
color_sberonline_ios-swift--canary.847.6861938533.swift
color_sberonline_kotlin--canary.847.6861938533.kt
color_sberonline_react-native--canary.847.6861938533.ts
color_sberonline_xml--canary.847.6861938533.xml
color_sberprime_ios-swift--canary.847.6861938533.swift
color_sberprime_kotlin--canary.847.6861938533.kt
color_sberprime_react-native--canary.847.6861938533.ts
color_sberprime_xml--canary.847.6861938533.xml
color_stylesSalute_ios-swift--canary.847.6861938533.swift
color_stylesSalute_kotlin--canary.847.6861938533.kt
color_stylesSalute_react-native--canary.847.6861938533.ts
color_stylesSalute_xml--canary.847.6861938533.xml
shadow
shadow_default_react-native--canary.847.6861938533.ts
shadow_plasma_b2c_react-native--canary.847.6861938533.ts
shadow_plasma_web_react-native--canary.847.6861938533.ts
shadow_sberHealth_react-native--canary.847.6861938533.ts
shadow_sbermarket_business_react-native--canary.847.6861938533.ts
shadow_sbermarket_metro_react-native--canary.847.6861938533.ts
shadow_sbermarket_react-native--canary.847.6861938533.ts
shadow_sbermarket_selgros_react-native--canary.847.6861938533.ts
shadow_sbermarket_wlbusiness_react-native--canary.847.6861938533.ts
shadow_sberonline_react-native--canary.847.6861938533.ts
shadow_sberprime_react-native--canary.847.6861938533.ts
shadow_stylesSalute_react-native--canary.847.6861938533.ts
spacing
spacing_default_react-native--canary.847.6861938533.ts
spacing_plasma_b2c_react-native--canary.847.6861938533.ts
spacing_plasma_web_react-native--canary.847.6861938533.ts
spacing_sberHealth_react-native--canary.847.6861938533.ts
spacing_sbermarket_business_react-native--canary.847.6861938533.ts
spacing_sbermarket_metro_react-native--canary.847.6861938533.ts
spacing_sbermarket_react-native--canary.847.6861938533.ts
spacing_sbermarket_selgros_react-native--canary.847.6861938533.ts
spacing_sbermarket_wlbusiness_react-native--canary.847.6861938533.ts
spacing_sberonline_react-native--canary.847.6861938533.ts
spacing_sberprime_react-native--canary.847.6861938533.ts
spacing_stylesSalute_react-native--canary.847.6861938533.ts
typo
typo_mage_ios-swift--canary.847.6861938533.swift
typo_mage_kotlin--canary.847.6861938533.kt
typo_mage_react-native--canary.847.6861938533.ts
typo_plasma_ios-swift--canary.847.6861938533.swift
typo_plasma_kotlin--canary.847.6861938533.kt
typo_plasma_react-native--canary.847.6861938533.ts
typo_ruler_ios-swift--canary.847.6861938533.swift
typo_ruler_kotlin--canary.847.6861938533.kt
typo_ruler_react-native--canary.847.6861938533.ts
typo_sage_ios-swift--canary.847.6861938533.swift
typo_sage_kotlin--canary.847.6861938533.kt
typo_sage_react-native--canary.847.6861938533.ts
typo_sbermarket_ios-swift--canary.847.6861938533.swift
typo_sbermarket_kotlin--canary.847.6861938533.kt
typo_sbermarket_react-native--canary.847.6861938533.ts
typo_soulmate_ios-swift--canary.847.6861938533.swift
typo_soulmate_kotlin--canary.847.6861938533.kt
typo_soulmate_react-native--canary.847.6861938533.ts
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@Yakutoc Yakutoc self-assigned this Nov 14, 2023
};

export const withTheme = (Story, context) => {
const Theme = themes[context.globals.theme];

Check warning

Code scanning / Semgrep

Semgrep Finding: gitlab.eslint.detect-object-injection Warning

Bracket object notation with user input is present, this might allow an attacker to access all properties of the object and even it's prototype, leading to possible code execution.
@Yakutoc Yakutoc marked this pull request as ready for review November 14, 2023 09:40
@Yakutoc Yakutoc requested review from TitanKuzmich and removed request for Yeti-or and neretin-trike November 14, 2023 09:40
@salute-developers salute-developers deleted a comment from Salute-Eva Nov 14, 2023
@salute-developers salute-developers deleted a comment from github-actions bot Nov 14, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Nov 14, 2023
@salute-developers salute-developers deleted a comment from github-actions bot Nov 14, 2023
@salute-developers salute-developers deleted a comment from Salute-Eva Nov 14, 2023
@salute-developers salute-developers deleted a comment from github-actions bot Nov 14, 2023
@Salute-Eva
Copy link
Contributor

Theme Builder app deployed!

http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-847/

@Salute-Eva
Copy link
Contributor

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr/pr-847/
b2c storybook: http://plasma.sberdevices.ru/pr/pr-847/b2c-storybook/

Copy link
Contributor

⚡ Component performance testing

Result: 🟢 OK

@Yakutoc Yakutoc added this pull request to the merge queue Nov 14, 2023
Merged via the queue into dev with commit e0a9a78 Nov 14, 2023
20 checks passed
@Yakutoc Yakutoc deleted the chore-b2c-sb-7 branch November 14, 2023 11:51
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

4 similar comments
@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva
Copy link
Contributor

🚀 This PR is included in version: @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected], @salutejs/[email protected] 🚀

@Salute-Eva Salute-Eva mentioned this pull request Nov 15, 2023
13 tasks
@Salute-Eva Salute-Eva mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants