Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4356: make placement optional for DropdownItem [master] #1722

Merged
merged 1 commit into from
Jan 24, 2025
Merged

PLASMA-4356: make placement optional for DropdownItem [master] #1722

merged 1 commit into from
Jan 24, 2025

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jan 24, 2025 •
edited by Salute-Eva
Loading

Core

Dropdown

  • сделали свойство placement для вложенных меню опциональным

What/why changed

Свойство placement для вложенных дропдаунов сделано опциональным.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@TitanKuzmich TitanKuzmich self-assigned this Jan 24, 2025
@TitanKuzmich TitanKuzmich marked this pull request as ready for review January 24, 2025 08:01
@TitanKuzmich TitanKuzmich changed the title PLASMA-make-placement-optional: make placement optional for DropdownItem PLASMA-4356: make placement optional for DropdownItem Jan 24, 2025
@TitanKuzmich TitanKuzmich changed the title PLASMA-4356: make placement optional for DropdownItem PLASMA-4356: make placement optional for DropdownItem [master] Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1722/

@Yakutoc Yakutoc added the Hotfix label Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1722/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1722/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1722/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1722/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1722/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1722/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1722/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1722/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1722/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1722/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1722/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1722/ui-storybook/

@Yakutoc Yakutoc merged commit 59e309f into master Jan 24, 2025
38 checks passed
@Yakutoc Yakutoc deleted the PLASMA-make-placement-optional branch January 24, 2025 09:13
@Yakutoc Yakutoc added the changelog-skip Exclude pull request changes from changelog label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neretin-trike neretin-trike neretin-trike approved these changes

@Yakutoc Yakutoc Yakutoc approved these changes

@Yeti-or Yeti-or Awaiting requested review from Yeti-or Yeti-or is a code owner

@shuga2704 shuga2704 Awaiting requested review from shuga2704 shuga2704 is a code owner

Assignees

@TitanKuzmich TitanKuzmich

Labels
changelog-skip Exclude pull request changes from changelog Hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TitanKuzmich @Yakutoc @neretin-trike