Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4257: fix Dropdown tokens and sizes in sdds-cs #1705

Merged
merged 3 commits into from
Jan 21, 2025
Merged

PLASMA-4257: fix Dropdown tokens and sizes in sdds-cs #1705

merged 3 commits into from
Jan 21, 2025

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Jan 15, 2025 •
edited by Salute-Eva
Loading

CORE

Dropdown

  • добавлен токен itemMargin
  • добавлен токен disclosureIconColor

SDDS-CS

Dropdown

  • в конфигурационных файлах и storybook оставлен только размер s
  • значения токенов приведены к макету
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@denivladislav denivladislav self-assigned this Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1705/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1705/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1705/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1705/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1705/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1705/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1705/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1705/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1705/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1705/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1705/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1705/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1705/ui-storybook/

@denivladislav denivladislav marked this pull request as ready for review January 16, 2025 06:20
@denivladislav denivladislav marked this pull request as draft January 16, 2025 06:21
@denivladislav denivladislav marked this pull request as ready for review January 17, 2025 10:00
@github-actions github-actions bot requested review from iljs and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 January 17, 2025 10:02
@denivladislav denivladislav requested review from Yakutoc and removed request for iljs January 17, 2025 10:02
@denivladislav denivladislav removed the request for review from Yakutoc January 21, 2025 11:02
@denivladislav denivladislav added this pull request to the merge queue Jan 21, 2025
Merged via the queue into dev with commit 3bef88c Jan 21, 2025
30 checks passed
@denivladislav denivladislav deleted the PLASMA-4257 branch January 21, 2025 11:53
@Salute-Eva Salute-Eva mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simashova simashova simashova approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denivladislav @vadim-kudr @TitanKuzmich @simashova