Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLASMA-3595: add extra content to Avatar #1696

Merged
merged 5 commits into from
Jan 17, 2025
Merged

PLASMA-3595: add extra content to Avatar #1696

merged 5 commits into from
Jan 17, 2025

Conversation

TitanKuzmich
Copy link
Contributor

@TitanKuzmich TitanKuzmich commented Jan 9, 2025

Core

Avatar

  • добавлен блок для отображения дополнительного контента в виде badge или counter

After:
image
image

What/why changed

Добавлен блок для отображения дополнительного контента в виде badge или counter

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1696/

@TitanKuzmich TitanKuzmich self-assigned this Jan 10, 2025
@TitanKuzmich TitanKuzmich marked this pull request as ready for review January 14, 2025 09:16
@github-actions github-actions bot requested review from denivladislav and shuga2704 and removed request for Yeti-or, Yakutoc, neretin-trike and shuga2704 January 14, 2025 09:16
@TitanKuzmich TitanKuzmich requested review from vadim-kudr and removed request for shuga2704 January 14, 2025 09:30
@denivladislav
Copy link
Contributor

denivladislav commented Jan 15, 2025

Заметил, что если в стори Accessibility выставить size="fit", то аватар становится шириной 0.

До твоих правок тоже воспроизводится.

accessibilityStoryFit

@TitanKuzmich
Copy link
Contributor Author

Заметил, что если в стори Accessibility выставить size="fit", то аватар становится шириной 0.

До твоих правок тоже воспроизводится.

accessibilityStoryFit

Ему нужен внешний контейнер. Добавлю

@TitanKuzmich TitanKuzmich added this pull request to the merge queue Jan 17, 2025
Merged via the queue into dev with commit 054059a Jan 17, 2025
30 checks passed
@TitanKuzmich TitanKuzmich deleted the PLASMA-3595 branch January 17, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants