chore: unified textfield and textarea api #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
fee6c78 to
bf4ee15
Compare
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
5791fd0 to
bf4ee15
Compare
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
85a103f to
859f40a
Compare
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
47bc295 to
1f03621
Compare
malilex
reviewed
Jan 14, 2025
| endContentColor: .surfaceInverseSolidPrimary.withOpacity(0.96), | ||
| textColorReadOnly: .surfaceInverseSolidPrimary.withOpacity(0.96), | ||
| captionColorReadOnly: .surfaceInverseSolidPrimary.withOpacity(0.56), | ||
| counterColorReadOnly: .surfaceInverseSolidPrimary.withOpacity(0.56), |
There was a problem hiding this comment.
Токены не корректные. В sdds-serv readOnly цвета отличаются только для backgroundColor и endContentColor.
И альфа уже есть в самих токенах. Только backgroundColorReadOnly и endContentColorReadOnly накладывают дополнительную альфу в 0.4.
There was a problem hiding this comment.
@malilex планировал настроить уже из конфига, но тогда сделаю уже здесь
malilex
reviewed
Jan 14, 2025
| startContentColor: .surfaceInverseSolidPrimary.withOpacity(0.96), | ||
| endContentColor: .surfaceInverseSolidPrimary.withOpacity(0.96), | ||
| textColorReadOnly: .surfaceInverseSolidPrimary.withOpacity(0.96), | ||
| captionColorReadOnly: .surfaceInverseSolidPrimary.withOpacity(0.56), |
malilex
reviewed
Jan 14, 2025
Themes/SDDSservTheme/SDDSButton/BasicButtonSize+ButtonSizeConfiguration.swift
Show resolved
Hide resolved
malilex
reviewed
Jan 14, 2025
Themes/SDDSservTheme/SDDSButton/IconButtonSize+ButtonSizeConfiguration.swift
Show resolved
Hide resolved
malilex
approved these changes
Jan 14, 2025
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
aa0b2ce to
1a5a3e4
Compare
vkaltyrin
force-pushed
the
feature/vakaltyrin/textfield-unification
branch
from
42ac85d to
aa2c2cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.