eslint flat config support #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanSilke
reviewed
Dec 24, 2024
package.json
Outdated
There was a problem hiding this comment.
Почему появились эти пакеты?
Кажется это лишнее и должно быть в ./packages/{config_name}.
SeanSilke
reviewed
Dec 24, 2024
package.json
Outdated
| "eslint-plugin-react": "7.37.2", | ||
| "eslint-plugin-react-hooks": "5.1.0", | ||
| "eslint-plugin-react-perf": "3.3.3", | ||
| "eslint-plugin-salute-rules": "1.0.0", |
There was a problem hiding this comment.
Никаких плагинов для eslint в корне не должно быть.
pamellix
force-pushed
the
SPEED-1579-eslint-9-support
branch
from
f17367d to
74fc958
Compare
SeanSilke
reviewed
Dec 25, 2024
package-lock.json
Outdated
There was a problem hiding this comment.
Все еще есть изменения в package-lock.json . А их не должно быть.
SeanSilke
reviewed
Dec 26, 2024
packages/eslint-config/README.md
Outdated
|
|
||
| ## Flat config for eslint | ||
|
|
||
| Also, we added a flat configuration for ESLint |
There was a problem hiding this comment.
Замени на.
Suggested change
| Also, we added a flat configuration for ESLint | |
| Also, we supports a flat configuration for ESLint |
SeanSilke
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: