Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README - have meta-states and sub-state headings. #169

Open
noelmcloughlin opened this issue Sep 19, 2019 · 6 comments
Open

README - have meta-states and sub-state headings. #169

noelmcloughlin opened this issue Sep 19, 2019 · 6 comments

Comments

@noelmcloughlin
Copy link
Member

I would recommend "Available States" section in README is split.

  • Available Meta-States
  • Available Sub-States

See example at https://github.com/saltstack-formulas/lvm-formula#available-meta-states

@baby-gnu
Copy link
Contributor

I agree that we should provide a better way to distinguish between meta and sub states and separate components. Maybe using the order in which they are called?

For example:

Available Meta states

Setup

  • template
  • template.subcomponent

Clean

  • template.subcomponent.clean
  • template.clean

Available substates

Setup

  • template.package
  • template.config
  • template.service
  • template.subcomponent.config

Clean

  • template.subcomponent.config.clean
  • template.service.clean
  • template.config.clean
  • template.package.clean

@baby-gnu
Copy link
Contributor

I think that if we have more than one configuration file, we should consider template.config as a meta-state and each individual file as sub-state, for example:

Available Meta states

  • template.config

Available substates

  • template.config.configfile1
  • template.config.configfile2

@noelmcloughlin
Copy link
Member Author

noelmcloughlin commented Sep 19, 2019

Substates are really useful for advanced users needing granularity, or building a solution needing to call one substate (i.e.setup a repository) without forcing entire formula on them.

Since many software has official API the sub-states can match API calls. See lvm-formula and devstack-formula.cli states for example - the API = SUB-STATES.

Related to this is #136 since there is duplication of states when the README is generated.

@myii
Copy link
Member

myii commented Sep 24, 2019

Available Meta states

...

Available substates

@baby-gnu While reviewing the lvm-formula PR, I'd like to suggest a minor adjustment to these headings:

-Available Meta states
+Available meta-states

...

-Available substates
+Available sub-states

@baby-gnu
Copy link
Contributor

@myii I completely agree, this was just a proposal for discussion.

Thanks.

@myii
Copy link
Member

myii commented Sep 24, 2019

@baby-gnu You're welcome, thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants