test(travis): + Basic Travis CI, bugfix & minor update

[noelmcloughlin]

This PR is relatively minor update doing three good things.

Bug:
Some OS rename thin-provisioning-toolspackage to device-mapper-persistent-data.

                 ID: lvm packages installed
           Function: pkg.installed
               Name: thin-provisioning-tools
             Result: False
            Comment: Error occurred installing package(s). Additional info follows:
              
              errors:
                  - Running scope as unit: run-rfa821170b6374a3c91ecd1c467648d53.scope
                    Last metadata expiration check: 0:00:26 ago on Sat Sep 21 12:10:05 2019.
                    No match for argument: thin-provisioning-tools
                    Error: Unable to find a match
            Started: 12:10:30.306255
           Duration: 3090.0000000000036 ms

Updated files are-

• osfamilymap.yaml is new file.
• osfingermap.yaml is new file
• osfamilymap.yaml is updated
• map.jinja is updated

Tests:;
For testing the PR I added basic Travis CI support.
See: https://travis-ci.org/noelmcloughlin/lvm-formula/builds/587945263

New files are:

• yamllint
• bin/kitchen
• .travis.yaml
• kitchen.yaml

Convention:
I renamed all remove.sls files to clean.sls and updated the README accordingly.
For backwards compatibility the remove.sls files invoke the clean state.

This PR introduces NO breaking changes - all good stuff!

[aboe76]

@noelmcloughlin what a work!! at first glance looking good.

[myii]

@noelmcloughlin Great job, I'll try to review (at least some of) this fairly soon.

[myii]

@noelmcloughlin In terms of the main files we manage leading to semantic-release, I've checked through and added another commit (454f0a1) with the last bits. See if you're happy with it; if not, feel free to remove it. Otherwise, this PR is also semantic-release ready.

---

Update: I pushed the commit again because I moved the README to the docs/ directory and reformatted it in general, while taking into account both:

• docs(readme): show only one level in table of contents template-formula#136
• README - have meta-states and sub-state headings. template-formula#169

[noelmcloughlin]

@thanks @myii, and @aboe76 for reviewing.

Yes adding semantic release makes sense.
In this PR I have learned more on Travis CI, and noted the additions required for semantic release.

[baby-gnu]

I'm only concerned about the duplicated lvm.clean, for me it must be changed.

Everything else can be addressed in futur PR, I noted them for the records.

Thanks for the work.

[baby-gnu]

As I understand, we sort the first component logically (profiles, files / pv, vg and finally lv) and the actions mostly alphabetically?

Could we sort the actions completely alphabetically since logically would be difficult?

This may be a dedicated PR.

[noelmcloughlin]

I could look at this but I'm unsure.

The README sequence follows an assumption that available storage is limited. Therefore , I would recommend doing moves/resizes/deletes/backup (housekeeping) before creates/extends/restores since it is easier to manage available storage that way imho.

The README is kinda a personal reminder that workflow probably matters..

.. do some housekeeping ...
lvm.pv.create
.. do some housekeeping ...
lvm.vg.extend
.. do some housekeeping ...
lvm.vg.create
.. do some housekeeping ...
lvm.lv.extend
.. do some housekeeping ...
lvm.lv.create

[baby-gnu]

Ok, do you mind adding a little comment to describe that?

[noelmcloughlin]

@baby-gnu thanks for the review.

I'd like to raise an new issue for your comments but this repo has issues disabled. Once that is sorted I'll raise that issue. Meanwhile I'll fix the major comment on README. now.

[noelmcloughlin]

Raised #1 and #2

[noelmcloughlin]

Thanks @myii and @baby-gnu for the reviews and comments - appreciated.

[saltstack-formulas-travis]

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀