-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(repo): Repository settings have been updated to accomodate deb key change #25
Conversation
I see there was an issue with the commit name. I've edited it. Not sure how to re-run the tests. |
@vveliev-tc I've done the update. Is that right? |
It would be nice to move all that logic to the yaml files but I'm not sure how much complexity they support. |
Anything else to be done to get this committed? @sticky-note ? |
@waynegemmell Seems legit. |
@waynegemmell Please rebase your commits and reword it to align with commitlint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase your commit and reword it/them to align with commitlint
Updated. Hopefully that's ok now. |
Thanks, just check few errors on commitlint job, please |
Hi @waynegemmell, sorry for the delay:
Thanks for your contribution btw |
Updated. Not sure why it's failing now. It doesn't look related to my code. |
Thanks for your contribution 🥇 |
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
None
Describe the changes you're proposing
Debian related distributions have depricated apt-key. This change implements the aptkey = False flag in newer versions of Ubuntu/Debian.
The repo is also cleared by setting the clean_file option to True
Pillar / config required to test the proposed changes
It's a fundamental change so any config will trigger it. Here's an example
powerdns:
config:
security-poll-suffix:
setgid: pdns
setuid: pdns
webserver-address: 0.0.0.0
webserver-allow-from: 10.0.0.0/8
webserver-port: 8083
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context