Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Repository settings have been updated to accomodate deb key change #25

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

waynegemmell
Copy link

@waynegemmell waynegemmell commented Sep 21, 2022

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None

Describe the changes you're proposing

Debian related distributions have depricated apt-key. This change implements the aptkey = False flag in newer versions of Ubuntu/Debian.
The repo is also cleared by setting the clean_file option to True

Pillar / config required to test the proposed changes

It's a fundamental change so any config will trigger it. Here's an example

powerdns:
config:
security-poll-suffix:
setgid: pdns
setuid: pdns
webserver-address: 0.0.0.0
webserver-allow-from: 10.0.0.0/8
webserver-port: 8083

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@waynegemmell waynegemmell changed the title fix(repo): Repository settings have been updated to accomodate deb key change. Repository clean added. fix(repo): Repository settings have been updated to accomodate deb key change Sep 21, 2022
@waynegemmell
Copy link
Author

I see there was an issue with the commit name. I've edited it. Not sure how to re-run the tests.

powerdns/repo.sls Outdated Show resolved Hide resolved
@waynegemmell
Copy link
Author

@vveliev-tc I've done the update. Is that right?

@waynegemmell
Copy link
Author

It would be nice to move all that logic to the yaml files but I'm not sure how much complexity they support.

@waynegemmell
Copy link
Author

Anything else to be done to get this committed? @sticky-note ?

@sticky-note
Copy link
Member

@waynegemmell Seems legit.

@sticky-note
Copy link
Member

@waynegemmell Please rebase your commits and reword it to align with commitlint

Copy link
Member

@sticky-note sticky-note left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your commit and reword it/them to align with commitlint

@waynegemmell
Copy link
Author

Updated. Hopefully that's ok now.

@sticky-note
Copy link
Member

sticky-note commented Feb 7, 2024

Thanks, just check few errors on commitlint job, please
https://github.com/saltstack-formulas/powerdns-formula/pull/25/checks?check_run_id=21221085532

@sticky-note
Copy link
Member

sticky-note commented Jul 5, 2024

Hi @waynegemmell, sorry for the delay:
Would you mind to fix this problems and rebase with master branch of this repo in order to be able to merge this PR please

⧗   input: fix(repo): Repo settings have been updated to handle key handling change.
✖   header must not be longer than 72 characters, current length is 73 [header-max-length]
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖   subject may not end with full stop [subject-full-stop]

Thanks for your contribution btw

@waynegemmell
Copy link
Author

Updated. Not sure why it's failing now. It doesn't look related to my code.

@sticky-note
Copy link
Member

sticky-note commented Sep 9, 2024

Thanks for your contribution 🥇
Sorry for the delay

@sticky-note sticky-note merged commit 971a8e7 into saltstack-formulas:master Sep 9, 2024
2 of 6 checks passed
@sticky-note
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants