Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaults): set enabled #46

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

tacerus
Copy link
Contributor

@tacerus tacerus commented Feb 15, 2024

Avoid render failure if called without a defined pillar and assume service should be enabled if not stated otherwise.

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Define a default value.

Pillar / config required to test the proposed changes

{}

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@daks daks requested a review from a team March 2, 2024 17:03
Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could indicate in the README that the service is enabled by default?

I tried that in my work for moosefs-formula.

Nothing mandatory.

Avoid render failure if called without a defined pillar and assume
service should be enabled if not stated otherwise.

Signed-off-by: Georg Pfuetzenreuter <[email protected]>
@tacerus
Copy link
Contributor Author

tacerus commented Mar 4, 2024

Hi @baby-gnu, sure, what about now?

Copy link
Member

@daks daks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baby-gnu baby-gnu merged commit dacb54e into saltstack-formulas:master Mar 12, 2024
2 of 8 checks passed
@tacerus tacerus deleted the enabled branch March 12, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants